Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add /debug/zip api to get useful debuginfo at once #9651

Merged
merged 5 commits into from
Mar 20, 2019
Merged

server: add /debug/zip api to get useful debuginfo at once #9651

merged 5 commits into from
Mar 20, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Mar 11, 2019 •
edited
Loading

What problem does this PR solve?

when we do troubleshooting often need multiple round-trips to get info from our custom.

to save time we need the ability to get more info at once, just curl or access

http://0.0.0.0:10080/debug/zip

What is changed and how it works?

get go pprof info in one file and maybe we can add more info in future, now after unzip we will got:

  • heap pprof(after gc)
  • mutex pprof
  • cpu pprof (default 10s)
  • full goroutine
  • tidb config info
  • tidb version info

Check List

Tests

  • Manual test (add detailed scripts or steps below)

can be curl and unzip and be go pprof or cat without error

Code changes

  • New code

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release 2.1

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 11, 2019 •
edited
Loading

Codecov Report

Merging #9651 into master will decrease coverage by 0.0651%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             master      #9651        +/-   ##
================================================
- Coverage   67.2409%   67.1757%   -0.0652%     
================================================
  Files           381        381                
  Lines         79874      79944        +70     
================================================
- Hits          53708      53703         -5     
- Misses        21381      21451        +70     
- Partials       4785       4790         +5

jackysp
jackysp reviewed Mar 12, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Please add it to the doc file.

jackysp
jackysp reviewed Mar 13, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 13, 2019

PTAL @tiancaiamao

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 20, 2019
@tiancaiamao tiancaiamao merged commit 490d405 into pingcap:master Mar 20, 2019
@lysu lysu mentioned this pull request Mar 22, 2019
Merged
jackysp pushed a commit that referenced this pull request Mar 25, 2019
@lysu @jackysp
server: add /debug/zip api to get useful debuginfo at once (#9651) (#…
4bd4cc8 
…9863)
@winoros winoros mentioned this pull request Jun 10, 2019
Merged
@nolouch nolouch mentioned this pull request Mar 18, 2024
Closed
@kennytm kennytm mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lysu @jackysp @tiancaiamao